Moves all thread related server properties under a "threads" group for each server implementation that has thread related properties (tomcat|jetty|undertow
).
The existing property accessors have been marked as deprecated. The old impl just delegates to the new one which allows us to test that fact in a deprecated test and then all subsequent downstream tests can rely on the new api (ie have deprecate test in a single place for each property).
@snicoll do the Boot docs get auto-generated from the @DeprecatedConfigurationProperty
s?
Closes gh-18620
Comment From: snicoll
@bono007 now that your other PR has been merged, would you be willing to rebase your proposal and include the max-queue-capacity
property that has been introduced for Jetty?
Comment From: onobc
@snicoll Absolutely. I will do that this evening. MR ready sometime in the next 24 hours.
If you need it before then let me know and I will make the time.
On Fri, Feb 14, 2020, 7:59 AM Stéphane Nicoll notifications@github.com wrote:
@bono007 https://github.com/bono007 now that your other PRs has been merged, would you be willing to rebase your proposal and include the max-queue-capacity property that has been introduced for Jetty?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-boot/pull/19475?email_source=notifications&email_token=AG4RTQ5JJZL6QKIWCS3QJJTRC2PULA5CNFSM4KANTAUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZDKQI#issuecomment-586298689, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4RTQ37LA7G7CZXM7FCUQDRC2PULANCNFSM4KANTAUA .
Comment From: onobc
@snicoll there were a few comments in the original proposal that we never resolved. I am ok with the proposal as is - if you want anything changed just let me know.
Comment From: snicoll
Thanks again @bono007