Hi,
this PR fixes #20424 by using org.elasticsearch.Version
instead of hardcoding the version.
Cheers, Christoph
Comment From: scottfrederick
At the time we did the upgrade in https://github.com/spring-projects/spring-boot/commit/d282eb619f62165a36fa91f419ec98b9034538d2, TestContainers was behind the latest version. This hard-coded version was the minimum required to make the tests work. If everything is back in sync now, it would be better to just remove VersionOverridingElasticsearchContainer
altogether and use the default container again.
Comment From: dreis2211
@scottfrederick ElasticsearchContainer
still uses 6.4.1, so it's not really in sync (maybe I got you wrong though). Nonetheless, it would work with the standard ElasticsearchContainer
.
Comment From: scottfrederick
No, I think you're right. If org.elasticsearch.Version
is coming from the Elasticsearch client lib that we're getting via dependency management (not from TestContainers as I first thought), then this seems like the safer change.