Comment From: snicoll
The upgrade broke our build, I've opened #20097
Comment From: snicoll
And https://github.com/sendgrid/sendgrid-java/pull/542/files broke some assertions as well.
Comment From: snicoll
The dependency tree between 4.4.1
and 4.4.3
is pretty wild.
Here it is for 4.4.1
:
[INFO] \- com.sendgrid:sendgrid-java:jar:4.4.1:compile
[INFO] +- com.sendgrid:java-http-client:jar:4.1.0:compile
[INFO] | +- org.apache.httpcomponents:httpcore:jar:4.4.13:compile
[INFO] | +- org.mockito:mockito-core:jar:3.1.0:compile
[INFO] | | +- net.bytebuddy:byte-buddy:jar:1.10.6:compile
[INFO] | | +- net.bytebuddy:byte-buddy-agent:jar:1.10.6:compile
[INFO] | | \- org.objenesis:objenesis:jar:2.6:compile
[INFO] | \- org.apache.httpcomponents:httpclient:jar:4.5.10:compile
[INFO] | \- commons-codec:commons-codec:jar:1.13:compile
[INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.10.2:compile
[INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.10.2:compile
[INFO] \- com.fasterxml.jackson.core:jackson-core:jar:2.10.2:compile
4.4.3
looks merely as follows:
[INFO] \- com.sendgrid:sendgrid-java:jar:4.4.3:compile
I have a feeling our build has more problems similar to https://github.com/spring-projects/spring-boot/issues/20097
Comment From: snicoll
4.4.3
is a single jar where dependencies are included (but not shaded). This is quite a problem of having potentially duplicated classes on the classpath. It also means our classpath tests in spring-boot-autoconfigure
need to take this library into account (when excluding Jackson for instance).
Good news, 4.4.4
is fixing that and restore the original release format, thanks @eshanholtz!