Hi,
this PR upgrades to org.asciidoctor:asciidoctor-gradle-jvm:3.0.0 and fixes related issues that prevented building the docs on that new version. This seems to overlap with #19785 so I've split the necessary commits.
Let me know what you think. Cheers, Christoph
Comment From: dreis2211
The current errors should be fixed with #19952 once merged. I only realized later that this blocks the Asciidoctor upgrade.
Comment From: wilkinsona
We should check if we need to tackle https://github.com/spring-io/spring-asciidoctor-extensions/issues/21 before merging this. That issue was opened as a placeholder so it may be that the extensions are already AsciidoctorJ 2.0 compatible.
Comment From: dreis2211
Is there anything I can help with, @wilkinsona ?
Comment From: wilkinsona
Thanks for the offer, @dreis2211. I think it's been taken care of thanks to @rwinch. I just need to double-check that I didn't break it when merging and then cut a release of the extensions.
Comment From: wilkinsona
The extensions have been released and Boot's now using them. I think we should now be good-to-go on this one.
Comment From: wilkinsona
The PDF generation failed when built locally. I think that's because we're using the configuration property JSON to generate the Asciidoc source. This makes the changes to use, for example, < rather than < have no effect. The < has been replaced with < again by the time the Asciidoctor processing is performed. I think we may need to do some escaping of the description in SingleConfigurationTableEntry instead.
Comment From: dreis2211
Interesting....I wonder why this didn't fail for me locally? I will take a look again. Sorry for the inconvenience.
Comment From: dreis2211
Pushed an updated version