Hi,
this tiny PR remove useless param when define function getCandidateConfigurations in class AutoConfigurationImportSelector & ImportAutoConfigurationImportSelector
Comment From: pivotal-issuemaster
@niubilityCode Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-issuemaster
@niubilityCode Thank you for signing the Contributor License Agreement!
Comment From: snicoll
Thanks for the PR. While technically the argument is unused, it is defined in a protected
method so an extension of this class may actually use it. It is technically a breaking change, too.
Flagging for team attention to see if someone else on the team remembers why the parameter was added.
Comment From: philwebb
I think it was added because obtaining the attributes might be expensive and we don't want subclasses to do it unnecessarily. Given it would be a breaking change, I don't think we should merge this PR.
Thanks anyway.