The original code
isFiltered(source, context, classFilter)
when true,
would cause dead circle.
Maybe new code is right.
Comment From: pivotal-issuemaster
@yilianhuaixiao Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-issuemaster
@yilianhuaixiao Thank you for signing the Contributor License Agreement!
Comment From: sbrannen
Have you encountered an exception or some form of infinite loop in your code regarding your proposed change?
If so, please elaborate.
In any case, please add a test to this PR that fails before the proposed change and passes after the proposed change.
Thanks
Comment From: yilianhuaixiao
I add the testcase. Before the bugfix, the testcase would cause infinite loop. After, the testcase could be passed.
Comment From: yilianhuaixiao
@sbrannen Thanks for your advice
Comment From: sbrannen
I add the testcase. Before the bugfix, the testcase would cause infinite loop. After, the testcase could be passed.
Thanks!
We'll look into it.
Comment From: sbrannen
Tentatively slated for 5.3 M2 for investigation.
Comment From: sbrannen
This has been merged into master
in 650cbeee1433aa38619691946c316d9d03a6512d and revised in 5442d8779aa6ae3d5495255853ef7be8a14ca6da.
Thanks!
@yilianhuaixiao, out of curiosity, since this code path is not executed in production code, how did you notice this bug?
Comment From: sbrannen
See also #25477
Comment From: yilianhuaixiao
@sbrannen I am learning the spring-core source codes rencently.