Enhance JDBC KeyHolder by allowing to retrieve single Generated Key that is not a Number. Generated key can be an UUID or something else. Devs shouldn't have to go manually through complex collections to get it.
Comment From: eXsio
Can you take a look at this please?
Comment From: eXsio
@sbrannen thank you for the review. All issues fixed.
Comment From: sbrannen
@sbrannen thank you for the review.
You're very welcome.
All issues fixed.
Great. That looks much cleaner now and much easier to review! Speaking of which, I'll make a final pass and merge this in soon.
Comment From: sbrannen
This has been merged into master
in b50cf9dad24bd798e28e6fe9293b25910c25bcb4 and slightly revised in cc301011b2edd6c6a02bfe5236482038c4b6473a.
Thanks!
Comment From: sbrannen
@eXsio, I'd be happy to add an @author
tag to KeyHolder
and GeneratedKeyHolder
for you, but I don't know your real name.
So if you'd like to be listed as an author and don't mind having your real name published, just let me know...
Comment From: eXsio
Hi Sam
That would be great! My name is Slawomir Dymitrow.
Thanks so much!
wt., 16 cze 2020, 14:42 użytkownik Sam Brannen notifications@github.com napisał:
@eXsio https://github.com/eXsio, I'd be happy to add an @author tag to KeyHolder and GeneratedKeyHolder for you, but I don't know your real name.
So if you'd like to be listed as an author and don't mind having your real name published, just let me know...
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spring-projects/spring-framework/pull/24655#issuecomment-644737848, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAO2E4KKOVRABEJ3BDDOKEDRW5SERANCNFSM4LDOSIJA .
Comment From: sbrannen
Hi Sam That would be great! My name is Slawomir Dymitrow. Thanks so much!
Done in 50391ad3d7a2f16de7466e1cd60b8ac49929fd06. 👍