Regarding https://github.com/spring-projects/spring-boot/issues/20839., this for the updates to support the new Micrometer NewRelicMeterRegistry changes introduced in 1.4.0, for the benefits noted in https://github.com/micrometer-metrics/micrometer/pull/1647.
The registry now uses NewRelicClientProvider implementations to support two New Relic Insights integration options, that result in the same metrics published. The first, is the current REST API approach and a second that delegates to the New Relic APM Java Agent if present and not explicitly configured to use the REST API. If the Agent is not present, the API implementation will be implicitly configured.
@shakuzen
Comment From: snicoll
Thanks for the PR. I prefer that we stick to configuring what Micrometer provides and only apply additional customizations if necessary. If a NewRelicClientProvider
bean is defined, we're going to use that which should cover those advanced use cases.
I've migrated our support in #20908
Comment From: neiljpowell
@snicoll @shakuzen Hi, can you clarify which customizations/options aren't acceptable? I'm happy to remove the added API client provider proxy config option. Or are you referring to the optional Agent provider all together? The Agent client provider is part of the NewRelicMeterRegistry. Delegation to the Agent as metric publishing option, was requested by others as well. Ok, I see the commit associated to the new Issue mentioned above. Thanks.